juneau-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Haumer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JUNEAU-15) StringUtils.parseNumber(String, Class<? extends Number>) returns doubles always as floats
Date Fri, 07 Oct 2016 18:32:20 GMT

    [ https://issues.apache.org/jira/browse/JUNEAU-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15555880#comment-15555880
] 

Peter Haumer commented on JUNEAU-15:
------------------------------------

[~jamesbognar] is this a fix that you could live with that I could deliver? 

> StringUtils.parseNumber(String, Class<? extends Number>) returns doubles always
as floats
> -----------------------------------------------------------------------------------------
>
>                 Key: JUNEAU-15
>                 URL: https://issues.apache.org/jira/browse/JUNEAU-15
>             Project: Juneau
>          Issue Type: Bug
>          Components: Code
>            Reporter: Peter Haumer
>
> When you serialize a bean with a member of type "double" and read it into an ObjectMap
the map will show the value now only with float precision. 
> The reason is that the parsing calls org.apache.juneau.internal.StringUtils.parseNumber(String,
Class<? extends Number>), which in Line 148 tests for float by "d >= -Float.MAX_VALUE
&& d <= Float.MAX_VALUE", but does not check if the precision required for the
string fits into the float. What about doing the test like this:
> {code}
> 	if (type == Double.class || type == Double.TYPE) {
> 		Double d = Double.valueOf(s);
> 		Float f = d.floatValue();
> 		if (isAutoDetect && (!isDecimal) && d.compareTo(new Double(f)) == 0)
> 			return f;
> 		return d;
> 	}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message