juneau-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Bognar <james.bog...@salesforce.com>
Subject Maven work
Date Wed, 03 Aug 2016 01:01:00 GMT
>Basically in all cases, they point to various IDE configurations.  I'm not
>saying you shouldn't use Eclipse (I did religiously until about 3 years
>ago), but we need to be able to accept non-eclipse users and have tooling
>in place that allows everyone to work the same using their favorite IDE.

I agree with that.

I vote that as long as these eclipse-specific files are not required or
interfere with non-eclipse IDEs, then we're good.  And the fewer, the
better.

It can be noted that the Artemis repo contains an eclipse .project file and
.settings directory.
On Tuesday, August 2, 2016, John D. Ament <johndament@apache.org> wrote:

> I'm afraid I'm explaining it a bit off.
>
> Basically, if the proper life cycles are defined within maven, then eclipse
> will execute them correctly without needing the eclipse generated files.
>
> I'll try to cite some other projects I've worked with here at the ASF to
> explain a bit better.
>
> ActiveMQ Artemis:
>
> https://github.com/apache/activemq-artemis/blob/master/docs/hacking-guide/en/ide.md
> Brooklyn: https://brooklyn.apache.org/v/latest/dev/env/ide/index.html
> DeltaSpike: http://deltaspike.apache.org/source.html (Section 2)
>
> Basically in all cases, they point to various IDE configurations.  I'm not
> saying you shouldn't use Eclipse (I did religiously until about 3 years
> ago), but we need to be able to accept non-eclipse users and have tooling
> in place that allows everyone to work the same using their favorite IDE.
>
> - John
>
> On Tue, Aug 2, 2016 at 8:30 PM Peter Haumer <phaumer@us.ibm.com> wrote:
>
> > I think your implications go in the wrong direction. Yes, everything can
> > be done with Maven and there is no Eclipse dependency. But, we also want
> to
> > use Eclipse and if we share the Eclipse files then other people using
> > Eclipse have an easier life.
> >
> > But, if we do introduce other dependencies then checkstyle is also a
> third
> > party tool you would make yourself dependent on; why is would that be
> more
> > desirable/more "inspecific" than Eclipse? Why not let us use the tools we
> > want and prescribe different ones?
> >
> >
> >
> >
> > Thanks and best regards,
> > Peter Haumer.
> >
> > ______________________________________________________________
> >
> > PETER HAUMER, Dr. rer. nat.
> > IBM zSystems Software
> > ______________________________________________________________
> >
> > [image: Inactive hide details for "John D. Ament" ---08/02/2016 04:07:51
> > PM---Everything you're describing is achievable with maven sol]"John D.
> > Ament" ---08/02/2016 04:07:51 PM---Everything you're describing is
> > achievable with maven solely, and does not rely on IDE specific tool
> >
> > From: "John D. Ament" <johndament@apache.org>
> > To: dev@juneau.incubator.apache.org
> > Date: 08/02/2016 04:07 PM
> > Subject: Re: Maven work
> > ------------------------------
> >
> >
> >
> >
> > Everything you're describing is achievable with maven solely, and does
> not
> > rely on IDE specific tooling.
> >
> > Basically, you're saying that you can only effectively work on Juneau if
> > you're using eclipse.  I want to challenge that.
> >
> > We need to be able to run code quality checks via maven, or some other
> > build tool.  Any formatting should be implemented using an inspecific
> tool,
> > like checkstyle or findbugs.
> >
> > John
> >
> > On Tue, Aug 2, 2016 at 6:30 PM James Bognar <james.bognar@salesforce.com
> >
> > wrote:
> >
> > > @Peter - Good point about the launcher files.
> > >
> > > Maybe a README.MD file in the root that points to the POM in the
> releng
> > > project?
> > >
> > > On Tue, Aug 2, 2016 at 6:22 PM, Peter Haumer <phaumer@us.ibm.com>
> wrote:
> > >
> > > > Hello.
> > > > I agree that we should keep the Eclipse files as James and I both
> work
> > > > with Eclipse and they do not impact any non-Eclipse users at all, but
> > > they
> > > > make our lives much easier as well as on-boarding new team members
> will
> > > be
> > > > much simplified. We can also provide launches to execute the most
> > common
> > > > command lines such as build. The only times the Eclipse specific file
> > > > change from user to user is if they are using significantly different
> > > > Eclipse versions, which is usually not a problem. We both have worked
> > for
> > > > years in Eclipse-centric projects and normally teams agree when to
> move
> > > on
> > > > to a new version. For now James and I agreed to work with Mars.2.
> > > >
> > > > There will be one key difference, though. The Parent Maven POM will
> be
> > > > inside a project folder as all files in Eclipse need to be inside a
> > > > project. I therefore placed our Maven parent in
> > org.apache.juneau.releng.
> > > > So user need to cd there and then run the "mvn package" command.
> > > >
> > > >
> > > >
> > > > Thanks and best regards,
> > > > Peter Haumer.
> > > >
> > > > ______________________________________________________________
> > > >
> > > > PETER HAUMER, Dr. rer. nat.
> > > > IBM zSystems Software
> > > > ______________________________________________________________
> > > >
> > > > [image: Inactive hide details for Craig Russell ---08/02/2016
> 02:21:00
> > > > PM---Hi John, > On Aug 2, 2016, at 2:13 PM, John D. Ament
> <johnd]Craig
> > > > Russell ---08/02/2016 02:21:00 PM---Hi John, > On Aug 2, 2016, at
> 2:13
> > > PM,
> > > > John D. Ament <johndament@apache.org> wrote:
> > > >
> > > > From: Craig Russell <craig.russell@oracle.com>
> > > > To: dev@juneau.incubator.apache.org
> > > > Date: 08/02/2016 02:21 PM
> > > > Subject: Re: Maven work
> > > > ------------------------------
> > > >
> > > >
> > > >
> > > > Hi John,
> > > >
> > > > > On Aug 2, 2016, at 2:13 PM, John D. Ament <johndament@apache.org>
> > > wrote:
> > > > >
> > > > > The traditional problem I've had with eclipse is that these files
> are
> > > > > dynamically generated.  I'm not sure we can apply headers to them
> for
> > > > > instance.  So when I open it, I may end up generating different
> > > versions
> > > > > than if you or James did.
> > > >
> > > > I’m not an expert on eclipse but I’ll take your description as
> gospel.
> > > >
> > > > If they are dynamically created when the project is first imported
> into
> > > an
> > > > eclipse workspace, they are completely unnecessary and should not be
> > > > distributed.
> > > >
> > > > If there is any intelligence in them that would help a user set up
> the
> > > > project in eclipse, and users modify them by their own actions in
> > > eclipse,
> > > > then they can be annotated as “git ignore” so they are not
> accidentally
> > > > published.
> > > >
> > > > In any case, they do not need license headers. I think we can tell
> RAT
> > to
> > > > ignore them.
> > > >
> > > > Craig
> > > >
> > > > >
> > > > > John
> > > > >
> > > > > On Tue, Aug 2, 2016 at 4:59 PM Craig Russell <
> > craig.russell@oracle.com
> > > >
> > > > > wrote:
> > > > >
> > > > >> Hi James, John,
> > > > >>
> > > > >> I think it is fine to have the source tree contain
> > > eclipse-tooling-only
> > > > >> artifacts if it makes life easier for eclipse users. I don’t
think
> > > there
> > > > >> are any licensing issues by including these artifacts.
> > > > >>
> > > > >> In any case, making it easier for users to exploit their tools
of
> > > choice
> > > > >> gets my +1. So I’m also keen on making sure there are maven
poms
> as
> > > > part of
> > > > >> the project, and good instructions for users on how to use their
> > tools
> > > > of
> > > > >> choice.
> > > > >>
> > > > >> Craig
> > > > >>
> > > > >>> On Aug 2, 2016, at 1:26 PM, James Bognar <
> > > james.bognar@salesforce.com>
> > > > >> wrote:
> > > > >>>
> > > > >>> I'll have to mess around with it a bit.  I was pretty sure
> Eclipse
> > > > would
> > > > >>> not recognize a directory as a project without the presence
of
> the
> > > > >> .project
> > > > >>> file.
> > > > >>>
> > > > >>> On Tue, Aug 2, 2016 at 4:22 PM, John D. Ament <
> > johndament@apache.org
> > > >
> > > > >> wrote:
> > > > >>>
> > > > >>>> Yes, its unusual to have those checked in.  Eclipse has
native
> > maven
> > > > >>>> support, or at least in a plugin (haven't used eclipse
in a
> > while).
> > > > >>>>
> > > > >>>> John
> > > > >>>>
> > > > >>>> On Tue, Aug 2, 2016 at 2:50 PM James Bognar <
> > > > >> james.bognar@salesforce.com>
> > > > >>>> wrote:
> > > > >>>>
> > > > >>>>> The .project/.classpath files are needed if you want
to import
> > > these
> > > > >>>>> directly into Eclipse projects.  The .settings directory
> contains
> > > all
> > > > >> the
> > > > >>>>> various Eclipse settings (e.g. code templates, formatting
> rules,
> > > > >> etc...).
> > > > >>>>>
> > > > >>>>> Is it unusual to have Eclipse-specific project files
in the
> repo?
> > > > >>>>>
> > > > >>>>> On Tue, Aug 2, 2016 at 2:39 PM, John D. Ament <
> > > > john.d.ament@gmail.com>
> > > > >>>>> wrote:
> > > > >>>>>
> > > > >>>>>> Once this is settled, I want to circle back to
understand why
> > > > >>>> .classpath,
> > > > >>>>>> .project etc are checked in.
> > > > >>>>>>
> > > > >>>>>> On Tue, Aug 2, 2016 at 2:31 PM James Bognar <
> > > > >>>> james.bognar@salesforce.com
> > > > >>>>>>
> > > > >>>>>> wrote:
> > > > >>>>>>
> > > > >>>>>>> @Peter - You're right....I missed those changes.
 I'm using a
> > new
> > > > >>>>> compare
> > > > >>>>>>> tool and I'm not quite used to it yet.  Check
it again to
> make
> > > > sure I
> > > > >>>>> got
> > > > >>>>>>> everything this time.
> > > > >>>>>>>
> > > > >>>>>>> I wouldn't worry about creating branches
right now.  Let's
> just
> > > > work
> > > > >>>>>>> directly against the master branch until
everything is set
> up.
> > > > >>>>>>>
> > > > >>>>>>>
> > > > >>>>>>>
> > > > >>>>>>> On Tue, Aug 2, 2016 at 2:03 PM, Peter Haumer
<
> > phaumer@us.ibm.com
> > > >
> > > > >>>>> wrote:
> > > > >>>>>>>
> > > > >>>>>>>> Ok, great. Strange that my other email
about Maven did not
> get
> > > > >>>>> through.
> > > > >>>>>>>>
> > > > >>>>>>>> I just created a new workpace based on
the apache git repo
> and
> > > it
> > > > >>>>> seems
> > > > >>>>>>>> that not all of my commits I did in the
old github repo were
> > > > brought
> > > > >>>>>> over.
> > > > >>>>>>>> For example, I had commented out some
asserts in the tests
> > that
> > > > were
> > > > >>>>>>>> failing with Java 7 and 8, the lib directories
are back, the
> > > > >>>> launches
> > > > >>>>>> use a
> > > > >>>>>>>> different execution env etc.
> > > > >>>>>>>>
> > > > >>>>>>>> How do you want me to continue working
on the Maven
> adoption?
> > > > >>>> Should I
> > > > >>>>>>>> create branch directly in "git://
> > > > >>>> git.apache.org/incubator-juneau.git"
> > > > >>>>>>>> and commit there? Should I create a fork
in
> > > > >>>>>>>> https://github.com/apache/incubator-juneau
and we work with
> > > Pull
> > > > >>>>>>>> Requests?
> > > > >>>>>>>>
> > > > >>>>>>>>
> > > > >>>>>>>> Thanks and best regards,
> > > > >>>>>>>> Peter Haumer.
> > > > >>>>>>>>
> > > > >>>>>>>>
> ______________________________________________________________
> > > > >>>>>>>>
> > > > >>>>>>>> PETER HAUMER, Dr. rer. nat.
> > > > >>>>>>>> IBM zSystems Software
> > > > >>>>>>>>
> ______________________________________________________________
> > > > >>>>>>>>
> > > > >>>>>>>> [image: Inactive hide details for James
Bognar ---08/02/2016
> > > > >>>> 08:41:08
> > > > >>>>>>>> AM---Yep....I see you. On Tue, Aug 2,
2016 at 11:30 AM,
> Peter
> > > > >>>>> Hau]James
> > > > >>>>>>>> Bognar ---08/02/2016 08:41:08 AM---Yep....I
see you. On Tue,
> > Aug
> > > > 2,
> > > > >>>>>> 2016 at
> > > > >>>>>>>> 11:30 AM, Peter Haumer <phaumer@us.ibm.com>
wrote:
> > > > >>>>>>>>
> > > > >>>>>>>> From: James Bognar <james.bognar@salesforce.com>
> > > > >>>>>>>> To: dev@juneau.incubator.apache.org
> > > > >>>>>>>> Date: 08/02/2016 08:41 AM
> > > > >>>>>>>> Subject: Re: test
> > > > >>>>>>>> ------------------------------
> > > > >>>>>>>>
> > > > >>>>>>>>
> > > > >>>>>>>>
> > > > >>>>>>>> Yep....I see you.
> > > > >>>>>>>>
> > > > >>>>>>>> On Tue, Aug 2, 2016 at 11:30 AM, Peter
Haumer <
> > > phaumer@us.ibm.com
> > > > >
> > > > >>>>>> wrote:
> > > > >>>>>>>>
> > > > >>>>>>>>>
> > > > >>>>>>>>> Hello.
> > > > >>>>>>>>> Checking if I can send emails. I
do receive them.
> > > > >>>>>>>>>
> > > > >>>>>>>>
> > > > >>>>>>>>
> > > > >>>>>>>>
> > > > >>>>>>>> --
> > > > >>>>>>>> James Bognar
> > > > >>>>>>>>
> > > > >>>>>>>>
> > > > >>>>>>>>
> > > > >>>>>>>>
> > > > >>>>>>>
> > > > >>>>>>>
> > > > >>>>>>> --
> > > > >>>>>>> James Bognar
> > > > >>>>>>>
> > > > >>>>>>
> > > > >>>>>
> > > > >>>>>
> > > > >>>>>
> > > > >>>>> --
> > > > >>>>> James Bognar
> > > > >>>>>
> > > > >>>>
> > > > >>>
> > > > >>>
> > > > >>>
> > > > >>> --
> > > > >>> James Bognar
> > > > >>
> > > > >> Craig L Russell
> > > > >> clr@apache.org
> > > > >>
> > > > >>
> > > > >>
> > > >
> > > > Craig L Russell
> > > > clr@apache.org
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> > > --
> > > James Bognar
> > >
> >
> >
> >
> >
>


-- 
James Bognar

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message