juneau-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Bognar <james.bog...@salesforce.com>
Subject Re: [DISCUSS] Maven naming conventions
Date Tue, 09 Aug 2016 20:44:43 GMT
This should all be done now except for the manifest and plugin.properties
files.  I don't know how to do those yet.

On Tue, Aug 9, 2016 at 9:22 AM, James Bognar <james.bognar@salesforce.com>
wrote:

>
>
> On Mon, Aug 8, 2016 at 9:22 PM, John D. Ament <johndament@apache.org>
> wrote:
>
>> Hey,
>>
>> Looking at our project, it seems we skip many of the maven norms.  I'd
>> like
>> to propose:
>>
>> - Directory names match artifact ID's.  E.g. instead of
>> "org.apache.juneau"
>> you would have a directory called "juneau-core" which matches the pom's
>> artifact ID.
>
>
> Agreed.
>
>
>> - We don't have MANIFEST.MF files checked in, instead have proper maven
>> configuration so they get generated properly.  This would be in the
>> maven-jar-plugin.
>>
>
> Ok.
>
>
>> - Files go in the standard directories.  Instead of
>> OSGI-INF/I10n/plugin.properties it should be under src/main/resources
>> with
>> proper configuration.  This probably means changing the packaging from jar
>> to bundle and using the org.apache.felix:maven-bundle-plugin (or whatever
>> it might be called these days).  LIkewise, don't rely on a war/web.xml for
>> tests, instead use src/test/resources/war/web.xml
>>
>
> The web.xml in the samples bundle is an old artifact.  We used to package
> the samples as a war file.  It can be deleted.
>
>
>> - Test class names should follow standard convention.  I still haven't
>> quite figured out what CT stands for, but most projects use "Test" as
>> their
>> suffix for test classes.  We may want to categorize, e.g. UnitTest vs
>> IntegrationTest.
>>
>
> Agreed.  Let's prefix them with Test*.
> CT_* was an old naming convention for Component Tests.
>
> --
> James Bognar
>



-- 
James Bognar

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message