jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pmoua...@apache.org
Subject svn commit: r1854230 - in /jmeter/trunk: src/components/org/apache/jmeter/assertions/gui/AssertionGui.java test/src/org/apache/jmeter/assertions/gui/AssertionGuiSpec.groovy
Date Sat, 23 Feb 2019 16:59:09 GMT
Author: pmouawad
Date: Sat Feb 23 16:59:09 2019
New Revision: 1854230

URL: http://svn.apache.org/viewvc?rev=1854230&view=rev
Log:
Add tests for AssertionGui

Commit missing change
Fix wrong test

Modified:
    jmeter/trunk/src/components/org/apache/jmeter/assertions/gui/AssertionGui.java
    jmeter/trunk/test/src/org/apache/jmeter/assertions/gui/AssertionGuiSpec.groovy

Modified: jmeter/trunk/src/components/org/apache/jmeter/assertions/gui/AssertionGui.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/assertions/gui/AssertionGui.java?rev=1854230&r1=1854229&r2=1854230&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/assertions/gui/AssertionGui.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/assertions/gui/AssertionGui.java Sat Feb
23 16:59:09 2019
@@ -313,7 +313,7 @@ public class AssertionGui extends Abstra
     /**
      * Initialize the GUI components and layout.
      */
-    private void init() { // WARNING: called from ctor so must not be overridden (i.e. must
be private or final)
+    void init() { // WARNING: called from ctor so must not be overridden (i.e. must be private
or final)
         setLayout(new BorderLayout());
         Box box = Box.createVerticalBox();
         setBorder(makeBorder());

Modified: jmeter/trunk/test/src/org/apache/jmeter/assertions/gui/AssertionGuiSpec.groovy
URL: http://svn.apache.org/viewvc/jmeter/trunk/test/src/org/apache/jmeter/assertions/gui/AssertionGuiSpec.groovy?rev=1854230&r1=1854229&r2=1854230&view=diff
==============================================================================
--- jmeter/trunk/test/src/org/apache/jmeter/assertions/gui/AssertionGuiSpec.groovy (original)
+++ jmeter/trunk/test/src/org/apache/jmeter/assertions/gui/AssertionGuiSpec.groovy Sat Feb
23 16:59:09 2019
@@ -58,12 +58,12 @@ class AssertionGuiSpec extends JMeterSpe
         when:
             sut.modifyTestElement(element)
         then:
-            element.getName().isEmpty()
+            element.getName().equals("Response Assertion")
             element.isTestFieldResponseData()
             element.getTestStrings().isEmpty()
-            reult.isAssumeSuccess()
-            result.isSubstringType()
-            !result.isNotType()
+            !element.getAssumeSuccess()
+            element.isSubstringType()
+            !element.isNotType()
     }
     
     def "configure has unexpected behaviour"() {



Mime
View raw message