jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fschumac...@apache.org
Subject svn commit: r1847980 - /jmeter/trunk/src/jorphan/org/apache/jorphan/gui/ObjectTableModel.java
Date Sun, 02 Dec 2018 11:22:07 GMT
Author: fschumacher
Date: Sun Dec  2 11:22:07 2018
New Revision: 1847980

URL: http://svn.apache.org/viewvc?rev=1847980&view=rev
Log:
Use log format strings

Part of #435 and Bugzilla Id: 62972

Modified:
    jmeter/trunk/src/jorphan/org/apache/jorphan/gui/ObjectTableModel.java

Modified: jmeter/trunk/src/jorphan/org/apache/jorphan/gui/ObjectTableModel.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/jorphan/org/apache/jorphan/gui/ObjectTableModel.java?rev=1847980&r1=1847979&r2=1847980&view=diff
==============================================================================
--- jmeter/trunk/src/jorphan/org/apache/jorphan/gui/ObjectTableModel.java (original)
+++ jmeter/trunk/src/jorphan/org/apache/jorphan/gui/ObjectTableModel.java Sun Dec  2 11:22:07
2018
@@ -104,18 +104,18 @@ public class ObjectTableModel extends De
 
         int numClasses = classes.size();
         if (numClasses != numHeaders){
-            log.warn("Header count="+numHeaders+" but classes count="+numClasses);
+            log.warn("Header count={} but classes count={}", numHeaders, numClasses);
         }
 
         // Functor count = 0 is handled specially
         int numWrite = writeFunctors.length;
         if (numWrite > 0 && numWrite != numHeaders){
-            log.warn("Header count="+numHeaders+" but writeFunctor count="+numWrite);
+            log.warn("Header count={} but writeFunctor count={}", numHeaders, numWrite);
         }
 
         int numRead = readFunctors.length;
         if (numRead > 0 && numRead != numHeaders){
-            log.warn("Header count="+numHeaders+" but readFunctor count="+numRead);
+            log.warn("Header count={} but readFunctor count={}", numHeaders, numRead);
         }
     }
 
@@ -138,7 +138,7 @@ public class ObjectTableModel extends De
     }
 
     public void addRow(Object value) {
-        log.debug("Adding row value: " + value);
+        log.debug("Adding row value: {}", value);
         if (objectClass != null) {
             final Class<?> valueClass = value.getClass();
             if (!objectClass.isAssignableFrom(valueClass)){
@@ -259,7 +259,7 @@ public class ObjectTableModel extends De
             try {
                 value = objectClass.getDeclaredConstructor().newInstance();
             } catch (ReflectiveOperationException e) {
-                log.error("Cannot create instance of class "+objectClass.getName(),e);
+                log.error("Cannot create instance of class {}", objectClass.getName(),e);
                 return false;
             }
         } else {
@@ -271,14 +271,14 @@ public class ObjectTableModel extends De
             if (setMethod != null
                  && !setMethod.checkMethod(value,getColumnClass(i))) {
                     status=false;
-                    log.warn(caller.getName()+" is attempting to use nonexistent "+setMethod.toString());
+                    log.warn("{} is attempting to use nonexistent {}", caller.getName(),
setMethod);
             }
             
             Functor getMethod = readFunctors.get(i);
             if (getMethod != null 
                  && !getMethod.checkMethod(value)) {
                     status=false;
-                    log.warn(caller.getName()+" is attempting to use nonexistent "+getMethod.toString());
+                    log.warn("{} is attempting to use nonexistent {}", caller.getName(),
getMethod);
             }
 
         }



Mime
View raw message