jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pmoua...@apache.org
Subject svn commit: r1776764 - in /jmeter/trunk/src/components/org/apache/jmeter/control: ForeachController.java ModuleController.java
Date Sat, 31 Dec 2016 14:52:10 GMT
Author: pmouawad
Date: Sat Dec 31 14:52:10 2016
New Revision: 1776764

URL: http://svn.apache.org/viewvc?rev=1776764&view=rev
Log:
Sonar : fix squid:CommentedOutCodeLine "This block of commented-out lines of code should be
removed. "

Modified:
    jmeter/trunk/src/components/org/apache/jmeter/control/ForeachController.java
    jmeter/trunk/src/components/org/apache/jmeter/control/ModuleController.java

Modified: jmeter/trunk/src/components/org/apache/jmeter/control/ForeachController.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/control/ForeachController.java?rev=1776764&r1=1776763&r2=1776764&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/control/ForeachController.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/control/ForeachController.java Sat Dec 31
14:52:10 2016
@@ -228,7 +228,6 @@ public class ForeachController extends G
         if (endOfArguments() // no more variables to iterate
                 ||loopCount >= getEndIndex() // we reached end index
                 ) {
-            // setDone(true);
             resetLoopCount();
             return null;
         }

Modified: jmeter/trunk/src/components/org/apache/jmeter/control/ModuleController.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/control/ModuleController.java?rev=1776764&r1=1776763&r2=1776764&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/control/ModuleController.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/control/ModuleController.java Sat Dec 31
14:52:10 2016
@@ -70,7 +70,8 @@ public class ModuleController extends Ge
         if (selectedNode == null) {
             this.restoreSelected();
         }
-        clone.selectedNode = selectedNode; // TODO ?? (JMeterTreeNode) selectedNode.clone();
+        // TODO Should we clone instead the selectedNode?
+        clone.selectedNode = selectedNode; 
         return clone;
     }
 



Mime
View raw message