jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pmoua...@apache.org
Subject svn commit: r1776654 - in /jmeter/trunk/src: components/org/apache/jmeter/assertions/ResponseAssertion.java components/org/apache/jmeter/visualizers/SearchTextExtension.java protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
Date Fri, 30 Dec 2016 22:54:00 GMT
Author: pmouawad
Date: Fri Dec 30 22:54:00 2016
New Revision: 1776654

URL: http://svn.apache.org/viewvc?rev=1776654&view=rev
Log:
sonar : fix code smell

Modified:
    jmeter/trunk/src/components/org/apache/jmeter/assertions/ResponseAssertion.java
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/SearchTextExtension.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java

Modified: jmeter/trunk/src/components/org/apache/jmeter/assertions/ResponseAssertion.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/assertions/ResponseAssertion.java?rev=1776654&r1=1776653&r2=1776654&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/assertions/ResponseAssertion.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/assertions/ResponseAssertion.java Fri Dec
30 22:54:00 2016
@@ -251,7 +251,7 @@ public class ResponseAssertion extends A
     }
     
     public void setToOrType() {
-        setTestType((getTestType() | OR));
+        setTestType(getTestType() | OR);
     }
 
     public void unsetOrType() {

Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/SearchTextExtension.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/SearchTextExtension.java?rev=1776654&r1=1776653&r2=1776654&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/SearchTextExtension.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/SearchTextExtension.java Fri
Dec 30 22:54:00 2016
@@ -240,9 +240,8 @@ public class SearchTextExtension impleme
     private Pattern createPattern(String textToFind) {
         // desactivate or not specials regexp char
         String textToFindQ = regexpChkBox.isSelected() ? textToFind : Pattern.quote(textToFind);
       
-        Pattern pattern = caseChkBox.isSelected() ? Pattern.compile(textToFindQ) :
+        return caseChkBox.isSelected() ? Pattern.compile(textToFindQ) :
             Pattern.compile(textToFindQ, Pattern.CASE_INSENSITIVE);
-        return pattern;
     }
     
     /**

Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java?rev=1776654&r1=1776653&r2=1776654&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
(original)
+++ jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
Fri Dec 30 22:54:00 2016
@@ -1476,14 +1476,6 @@ public abstract class HTTPSamplerBase ex
     }
 
     /**
-     * {@inheritDoc}
-     */
-    @Override
-    public Object clone() {
-        return super.clone();
-    }
-
-    /**
      * Iteratively download the redirect targets of a redirect response.
      * <p>
      * The returned result will contain one subsample for each request issued,



Mime
View raw message