jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pmoua...@apache.org
Subject svn commit: r1760154 - in /jmeter/trunk: src/core/org/apache/jmeter/report/processor/StatisticsSummaryConsumer.java xdocs/changes.xml
Date Sat, 10 Sep 2016 12:41:06 GMT
Author: pmouawad
Date: Sat Sep 10 12:41:06 2016
New Revision: 1760154

URL: http://svn.apache.org/viewvc?rev=1760154&view=rev
Log:
Bug 60107 - Report / Dashboard : In StatisticSummary, TransactionController SampleResult makes
Total line wrong
Bugzilla Id: 60107

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/report/processor/StatisticsSummaryConsumer.java
    jmeter/trunk/xdocs/changes.xml

Modified: jmeter/trunk/src/core/org/apache/jmeter/report/processor/StatisticsSummaryConsumer.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/report/processor/StatisticsSummaryConsumer.java?rev=1760154&r1=1760153&r2=1760154&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/report/processor/StatisticsSummaryConsumer.java
(original)
+++ jmeter/trunk/src/core/org/apache/jmeter/report/processor/StatisticsSummaryConsumer.java
Sat Sep 10 12:41:06 2016
@@ -45,7 +45,16 @@ public class StatisticsSummaryConsumer e
         super(true);
     }
 
-    void aggregateSample(Sample sample, StatisticsSummaryData data) {
+    /**
+     * 
+     * @param sample {@link Sample}
+     * @param data {@link StatisticsSummaryData}
+     * @param isOverall boolean indicatin if aggregation concerns the Overall results in
which case we ignore Transaction Controller's SampleResult
+     */
+    private void aggregateSample(Sample sample, StatisticsSummaryData data, boolean isOverall)
{
+        if(isOverall && sample.isController()) {
+            return;
+        }
         data.incTotal();
         data.incBytes(sample.getReceivedBytes());
         data.incBytes(sample.getSentBytes());
@@ -93,8 +102,8 @@ public class StatisticsSummaryConsumer e
         }
 
         if(!sample.isEmptyController()) {
-            aggregateSample(sample, data);
-            aggregateSample(sample, overallData);
+            aggregateSample(sample, data, false);
+            aggregateSample(sample, overallData, true);
         }
     }
 

Modified: jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1760154&r1=1760153&r2=1760154&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
+++ jmeter/trunk/xdocs/changes.xml [utf-8] Sat Sep 10 12:41:06 2016
@@ -211,6 +211,7 @@ Summary
     <li><bug>60090</bug>Report / Dashboard : Empty Transaction Controller
should not count in metrics</li>
     <li><bug>60103</bug>Report / Dashboard : Requests summary includes
Transaction Controller leading to wrong percentage</li>
     <li><bug>60105</bug>Report / Dashboard : Report requires Transaction
Controller "generate parent sample" option to be checked , fix related issues</li>
+    <li><bug>60107</bug>Report / Dashboard : In StatisticSummary, TransactionController
SampleResult makes Total line wrong</li>
 </ul>
 
  <!--  =================== Thanks =================== -->



Mime
View raw message