jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pmoua...@apache.org
Subject svn commit: r1724619 - in /jmeter/trunk: src/core/org/apache/jmeter/config/gui/ArgumentsPanel.java xdocs/changes.xml
Date Thu, 14 Jan 2016 14:13:32 GMT
Author: pmouawad
Date: Thu Jan 14 14:13:32 2016
New Revision: 1724619

URL: http://svn.apache.org/viewvc?rev=1724619&view=rev
Log:
Bug 58861 - When clicking on up, down or detail while in a cell of the argument panel, newly
added content is lost
#resolve #77
Bugzilla Id: 58861

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/config/gui/ArgumentsPanel.java
    jmeter/trunk/xdocs/changes.xml

Modified: jmeter/trunk/src/core/org/apache/jmeter/config/gui/ArgumentsPanel.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/config/gui/ArgumentsPanel.java?rev=1724619&r1=1724618&r2=1724619&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/config/gui/ArgumentsPanel.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/config/gui/ArgumentsPanel.java Thu Jan 14 14:13:32
2016
@@ -383,9 +383,11 @@ public class ArgumentsPanel extends Abst
      * Move a row down
      */
     private void moveDown() {
-        cancelEditing();
-
+        //get the selected rows before stopping editing
+        // or the selected will be unselected
         int[] rowsSelected = table.getSelectedRows();
+        GuiUtils.stopTableEditing(table);
+        
         if (rowsSelected.length > 0 && rowsSelected[rowsSelected.length - 1] <
table.getRowCount() - 1) {
             table.clearSelection();
             for (int i = rowsSelected.length - 1; i >= 0; i--) {
@@ -402,9 +404,11 @@ public class ArgumentsPanel extends Abst
      *  Move a row down
      */
     private void moveUp() {
-        cancelEditing();
-
+        //get the selected rows before stopping editing
+        // or the selected will be unselected
         int[] rowsSelected = table.getSelectedRows();
+        GuiUtils.stopTableEditing(table);
+        
         if (rowsSelected.length > 0 && rowsSelected[0] > 0) {
             table.clearSelection();
             for (int rowSelected : rowsSelected) {
@@ -420,9 +424,11 @@ public class ArgumentsPanel extends Abst
      * Show Row Detail
      */
     private void showDetail() {
-        cancelEditing();
-
+        //get the selected rows before stopping editing
+        // or the selected will be unselected
         int[] rowsSelected = table.getSelectedRows();
+        GuiUtils.stopTableEditing(table);
+        
         if (rowsSelected.length == 1) {
             table.clearSelection();
             RowDetailDialog detailDialog = new RowDetailDialog(tableModel, rowsSelected[0]);

Modified: jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1724619&r1=1724618&r2=1724619&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml (original)
+++ jmeter/trunk/xdocs/changes.xml Thu Jan 14 14:13:32 2016
@@ -219,6 +219,7 @@ Summary
     <li><bug>57804</bug>HTTP Request doesn't reuse cached SSL context when
using Client Certificates in HTTPS (only fixed for HttpClient4 implementation)</li>
     <li><bug>58800</bug>proxy.pause default value , fix documentation</li>
     <li><bug>58844</bug>Buttons enable / disable is broken in the arguments
panel. Contributed by Benoit Wiart (benoit dot wiart at gmail.com)</li>
+    <li><bug>58861</bug>When clicking on up, down or detail while in a
cell of the argument panel, newly added content is lost. Contributed by Benoit Wiart (benoit
dot wiart at gmail.com)</li>
 </ul>
 
 <h3>Other Samplers</h3>



Mime
View raw message