jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1407840 - /jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/TCLogParser.java
Date Sat, 10 Nov 2012 15:48:04 GMT
Author: sebb
Date: Sat Nov 10 15:48:03 2012
New Revision: 1407840

URL: http://svn.apache.org/viewvc?rev=1407840&view=rev
Log:
Add TODO

Modified:
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/TCLogParser.java

Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/TCLogParser.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/TCLogParser.java?rev=1407840&r1=1407839&r2=1407840&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/TCLogParser.java
(original)
+++ jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/TCLogParser.java
Sat Nov 10 15:48:03 2012
@@ -79,6 +79,15 @@ import org.apache.log.Logger;
 public class TCLogParser implements LogParser {
     protected static final Logger log = LoggingManager.getLoggerForClass();
 
+    /*
+     * TODO should these fields be public?
+     * They don't appear to be used externally.
+     * 
+     * Also, are they any different from HTTPConstants.GET etc. ?
+     * In some cases they seem to be used as the method name from the Tomcat log.
+     * However the RMETHOD field is used as the value for HTTPSamplerBase.METHOD,
+     * for which HTTPConstants is most approriate.
+     */
     public static final String GET = "GET";
 
     public static final String POST = "POST";



Mime
View raw message