jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1226911 - in /jmeter/trunk/src: components/org/apache/jmeter/assertions/ResponseAssertion.java jorphan/org/apache/commons/cli/avalon/CLOptionDescriptor.java
Date Tue, 03 Jan 2012 18:49:02 GMT
Author: sebb
Date: Tue Jan  3 18:49:01 2012
New Revision: 1226911

URL: http://svn.apache.org/viewvc?rev=1226911&view=rev
Log:
Don't use > 0 for checking masked values (Findbugs)

Modified:
    jmeter/trunk/src/components/org/apache/jmeter/assertions/ResponseAssertion.java
    jmeter/trunk/src/jorphan/org/apache/commons/cli/avalon/CLOptionDescriptor.java

Modified: jmeter/trunk/src/components/org/apache/jmeter/assertions/ResponseAssertion.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/assertions/ResponseAssertion.java?rev=1226911&r1=1226910&r2=1226911&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/assertions/ResponseAssertion.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/assertions/ResponseAssertion.java Tue Jan
 3 18:49:01 2012
@@ -222,23 +222,23 @@ public class ResponseAssertion extends A
     }
 
     public boolean isEqualsType() {
-        return (getTestType() & EQUALS) > 0;
+        return (getTestType() & EQUALS) != 0;
     }
 
     public boolean isSubstringType() {
-        return (getTestType() & SUBSTRING) > 0;
+        return (getTestType() & SUBSTRING) != 0;
     }
 
     public boolean isContainsType() {
-        return (getTestType() & CONTAINS) > 0;
+        return (getTestType() & CONTAINS) != 0;
     }
 
     public boolean isMatchType() {
-        return (getTestType() & MATCH) > 0;
+        return (getTestType() & MATCH) != 0;
     }
 
     public boolean isNotType() {
-        return (getTestType() & NOT) > 0;
+        return (getTestType() & NOT) != 0;
     }
 
     public void setToContainsType() {

Modified: jmeter/trunk/src/jorphan/org/apache/commons/cli/avalon/CLOptionDescriptor.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/jorphan/org/apache/commons/cli/avalon/CLOptionDescriptor.java?rev=1226911&r1=1226910&r2=1226911&view=diff
==============================================================================
--- jmeter/trunk/src/jorphan/org/apache/commons/cli/avalon/CLOptionDescriptor.java (original)
+++ jmeter/trunk/src/jorphan/org/apache/commons/cli/avalon/CLOptionDescriptor.java Tue Jan
 3 18:49:01 2012
@@ -74,7 +74,7 @@ public final class CLOptionDescriptor {
         m_name = name;
         m_flags = flags;
         m_description = description;
-        m_incompatible = ((flags & DUPLICATES_ALLOWED) > 0) ? new int[0] : new int[]
{ id };
+        m_incompatible = ((flags & DUPLICATES_ALLOWED) != 0) ? new int[0] : new int[]
{ id };
     }
 
 



Mime
View raw message