jmeter-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pmoua...@apache.org
Subject svn commit: r1225787 - in /jmeter/trunk/src/core/org/apache/jmeter: save/CSVSaveService.java util/JSR223TestElement.java
Date Fri, 30 Dec 2011 10:30:13 GMT
Author: pmouawad
Date: Fri Dec 30 10:30:12 2011
New Revision: 1225787

URL: http://svn.apache.org/viewvc?rev=1225787&view=rev
Log:
Added TODO

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/save/CSVSaveService.java
    jmeter/trunk/src/core/org/apache/jmeter/util/JSR223TestElement.java

Modified: jmeter/trunk/src/core/org/apache/jmeter/save/CSVSaveService.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/save/CSVSaveService.java?rev=1225787&r1=1225786&r2=1225787&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/save/CSVSaveService.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/save/CSVSaveService.java Fri Dec 30 10:30:12 2011
@@ -128,7 +128,7 @@ public final class CSVSaveService {
         final boolean errorsOnly = resultCollector.isErrorLogging();
         final boolean successOnly = resultCollector.isSuccessOnlyLogging();
         try {
-            dataReader = new BufferedReader(new FileReader(filename));
+            dataReader = new BufferedReader(new FileReader(filename)); // TODO Charset ?
             dataReader.mark(400);// Enough to read the header column names
             // Get the first line, and see if it is the header
             String line = dataReader.readLine();

Modified: jmeter/trunk/src/core/org/apache/jmeter/util/JSR223TestElement.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/util/JSR223TestElement.java?rev=1225787&r1=1225786&r2=1225787&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/util/JSR223TestElement.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/util/JSR223TestElement.java Fri Dec 30 10:30:12
2011
@@ -128,7 +128,7 @@ public abstract class JSR223TestElement 
         if (scriptFile.exists()) {
             BufferedReader fileReader = null;
             try {
-                fileReader = new BufferedReader(new FileReader(scriptFile));
+                fileReader = new BufferedReader(new FileReader(scriptFile)); // TODO Charset
?
                 return scriptEngine.eval(fileReader);
             } finally {
                 IOUtils.closeQuietly(fileReader);



Mime
View raw message