incubator-ivy-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles Scokart (JIRA)" <>
Subject [jira] Updated: (IVY-493) buildlist broken
Date Wed, 02 May 2007 14:14:15 GMT


Gilles Scokart updated IVY-493:

    Attachment: IVY-493.patch

Here is already a patch that fix the regression.

I investigated a little bit further.

In 1.4, the buildlist was not using the revision number of the dependency because the revision
of the modules loaded were null when the source ivy.xml doesn't contains a version number.
(revision 502534 in ModuleRevisionID).

In 2.0 the version number is taken into account, which is not a problem if the asked version
is latest.integration or latest.release but is a problem if it is anything else.  (In my case
it was ${depX.revision} because I manage the dependency version number from my ant script).

The way I fix it was to not compare version numbers when the version number of the lodaed
ivy.xml file is working@hostname.

I also added some debug traces (the traces where not really usefull) and updated the unit-test
in order to test different cases that were not tested before (loaded ivy.xml has no revision
or a different revision than the asked dependencies and asked revision being latest.integration).

> buildlist broken
> ----------------
>                 Key: IVY-493
>                 URL:
>             Project: Ivy
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-alpha-1
>            Reporter: Gilles Scokart
>            Priority: Blocker
>             Fix For: 2.0.0-alpha-2
>         Attachments: IVY-493.patch
> buildlist doesn't sort the modules anymore in 2.0-alpha1 when local ivy files doesn't
contains a revision.  
> I traced back the problem to the ModuleDescriptorSorter that was asuming that the revision
is null in such a case, while it is now 'working@hostname'.
> I will post the patch soon.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message