incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel B. Widdis" <wid...@gmail.com>
Subject Re: IP clearance officer for accepting Terraform
Date Fri, 25 Jun 2021 21:30:28 GMT
> I would expect any one making total commits of 100s, 1,000s or more lines
of code major/significant.

That assumes it's their own code.  There are three contributors in the
1000s of lines range, and while these contributors have done a great
service to the project, the vast majority of those thousands of lines of
code do not represent their own intellectual property.

The top contributor appears to have added 352,925 lines of code, but most
of that is transferring code from other sources

The 16 commits [1] include:
 - transfer of cloudstack code provider from another source (4 commits:
1118 lines, 12,193 lines, 124,297 lines and 188,280 lines)
 - transfer of website docs from another source and a few commits to fix
various links
 - a makefile from another source
 - .gitignore list (hard to argue it's copyrightable)
 - An issue template (creative, but not code)
 - Typo fixes

The vast majority of the 3rd top contributor's 79,555 lines of code are a
single commit transferring 233.853 lines of code from another source [2],
much of which were later deleted when obsolete

The 6th top contributor's 19,413 lines are mostly from a single 19,378-line
commit of code from another source [3].

I do not mean to belittle the herculean effort by these individuals.  This
is a lot of work.  The project in its current form wouldn't exist without
the effort they put in.

I would be pressed to argue they have 352,925, 79,555, and 19,413 lines,
respectively, of IP for which they have legal standing to discuss the
licensing of, vs. the original license of the code they transferred.  I
would wager that the individual with the most IP in the current iteration
of the project is someone other than these three.

> I’m not sure that due diligence has been done here, please provide
documentation that shows otherwise.

Certainly this is a reasonable request, but due diligence should likely be
a review of every commit to the project, not just lines above some
arbitrary threshold, determining the license of code transferred from
elsewhere (and not the committer's opinion), eliminating non-copyrightable
contributions (whitespace, typo fixes, lists of files, URL changes), and
obtaining concurrence from anyone who has committed remaining code,
regardless of how few lines they committed.

1. Commits · xanzy/terraform-provider-cloudstack (github.com)
<https://github.com/xanzy/terraform-provider-cloudstack/commits?author=grubernaut>
2. Merge pull request #64 from terraform-providers/svh/f-cs-4.12 ·
xanzy/terraform-provider-cloudstack@07febb7 (github.com)
<https://github.com/xanzy/terraform-provider-cloudstack/commit/07febb7a6ba78e27224b37ad41e23bc4634b18b4>
3. vendor: github.com/hashicorp/terraform/...@v0.10.0 ·
xanzy/terraform-provider-cloudstack@29c9bb4
<https://github.com/xanzy/terraform-provider-cloudstack/commit/29c9bb4593b98f47add0c3eb69253290fe02a893>
4. IP Clearance for Terraform Provider and Go SDK · Issue #5159 ·
apache/cloudstack (github.com)
<https://github.com/apache/cloudstack/issues/5159>


On Wed, Jun 23, 2021 at 2:53 AM Justin Mclean <justin@classsoftware.com>
wrote:

> Hi,
>
> > I've been following this thread and continue to see phrases such as
> "major contributors" and "significant contributions”.
>
> That may be a bit nebulous depending on the exact contributions involved,
> but I would expect any one making total commits of 100s, 1,000s or more
> lines of code major/significant. You can see the stats for this repo here
> [1]
>
> Thanks,
> Justin
>
> 1.
> https://github.com/xanzy/terraform-provider-cloudstack/graphs/contributors
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

-- 
Dan Widdis

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message