incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hans Van Akelyen <hans.van.akel...@gmail.com>
Subject Re: [VOTE] Release Apache Hop (incubating) 0.99-rc1
Date Fri, 11 Jun 2021 08:51:07 GMT
Hi Justin,

That file should be switched to the standard ASF header and is part of the
original code and covered by the notice file.

As for the no header in hpl and hwf files, these are files created using
the application and are used for samples and for our integration testing
framework. This framework is an extension on our unit tests mainly used to
see if all functionality is working and that we have no regressions.
As they are created using the application no header is included, they are
not manually created files.

Cheers,
Hans

On Fri, 11 Jun 2021 at 09:36, Justin Mclean <justin@classsoftware.com>
wrote:

> Hi,
>
> -1 (binding)
>
> This 3rd party file [1] is not mentioned in LICENSE. While this is just
> one file my concern is that that this may indicate a bigger issue where
> headers of 3rd party files have been changed.
>
> I checked:
> - incubating in name
> - signatures and hash are fine
> - LICENSE is missing a mention from a 3rd party file
> - No unexpected binary files
> - There is quite a number of files without ASF headers I assume it could
> be added to some of these (e.g. .hpl or .hwf files)
> - Didn't compile from source
>
> Kind Regards,
> Justin
>
> 1. ./core/src/test/java/org/apache/hop/core/sql/SqlFieldsUnitTest.java
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message