incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Release Apache Hop (incubating) 0.50-rc2
Date Sun, 03 Jan 2021 01:59:19 GMT
HI,

Sorry but it’s -1 (binding) as it contains Category B source code and header issues and
is not using the WIP disclaimer. [1]

 I suggest you use the work in progress disclaimer, and in it list the issues that need to
be fixed before graduation. Fixing some of teh header issues would make it easier to review
as well.

I checked:
- Incubating in name
- DISCLAIMER exists but is not work in progress 
- LICENSE is missing mention of 3rd party included software [2][3][5][6]
- NOTICE may need updating if the release contains code from Apache Hadoop
- There a large number of files that are missing ASF headers. This makes it hard to review.
- There are a large number of files without correct headers copyright  Hitachi Vantara.
- Files incorrectly have the ASF header onto of anther license header e.g [4]
- Includes Category B course code
- No unexpected binary files
- Unable to compile on OSX but not sure if that’s a supported platform. It gets to step
467 out of 474. (Hop Assemblies Plugins Dist)

Thanks,
Justin

1. https://incubator.apache.org/policy/incubation.html#work_in_progress_disclaimer
2. OpenSansLight font
3. ./plugins/actions/ftp/src/main/java/org/apache/hop/workflow/actions/ftpput/FtpClient.java
4. ./ui/src/main/java/org/apache/hop/ui/pipeline/transforms/tableinput/SqlValuesHighlight.java
5. ./assemblies/static/src/main/resources/LICENSE ( Copyright (c) 2005, European Commission
project)
6 ./assemblies/static/src/main/resources/docs/English/welcome/css/bootstrap.css
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message