incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dave Fisher <w...@apache.org>
Subject Re: [VOTE] Heron Release 0.20.3-incubating Release Candidate 8
Date Tue, 08 Dec 2020 15:32:39 GMT


> On Dec 7, 2020, at 10:04 PM, Justin Mclean <justin@classsoftware.com> wrote:
> 
> HI,
> 
> -1 (binding) due to license and notice issues
> 
> I checked:
> - incubating in name
> - LICENSE has issues (see below)
> - NOTICE has wrong year
> - DISCLAIMER exists (not WIP one)
> - no unexpected binary files
> - ASF files have ASF headers
> 
> I’m a little confused by the LICENSE file. 
> 
> First off it uses URLs to link to the LICENSE text, the full license text often needs
to be included as part of the license conditions (from ALv2, MIT and BSD style licenses so
need to be included in the releases. While the URL are useful they can break over time or
worse the license change, you should point to the license file in the licenses directory.
Also part of the BSD and MIT licences include a copyright line and this will vary with each
bit of included code.

You missed a licenses directory.

> 
> JSXTransformer is listed under the Apache 2.0, MIT, BSD 2 clause and BSD 3 clause licenses.
It may be that this files include 3rd party code under different licenses or the file itself
is under multiple licenses. If it was under multiple licenses you would generally select which
one you want to use. If not then each of those pieces of 3rd party code is likely to have
its own name and copyright holder (for MIT and BSD licenses) which need to be included or
pointed to by the LICENSE file.

This resource gives a single MIT license:

https://cdnjs.com/libraries/react/0.10.0

> 
> LICENSE is also missing the license for the trykker font and may be missing other things.

Good catch as that file was in the .rat-excludes. This font is Class B and should not be included.
Heron will need to find another Serif Font.

https://scripts.sil.org/cms/scripts/page.php?item_id=OFL_web

A review of the .rat-excludes is needed.

Regards,
Dave

> 
> Thanks,
> Justin
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message