incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dave Fisher <wave4d...@comcast.net>
Subject Re: [VOTE] Release Apache ECharts (incubating) 4.3.0 (release candidate 2)
Date Thu, 12 Sep 2019 13:42:21 GMT
Inline 

Sent from my iPhone

> On Sep 12, 2019, at 3:18 AM, SHUANG SU <sushuang0322@gmail.com> wrote:
> 
> Justin & Furkan, thank you for the detailed check!
> 
> There is a relevant build instruction in
> https://echarts.apache.org/en/tutorial.html#Create%20Custom%20Build%20of%20ECharts
> and the link is listed in `README.md`.
> 
> But I also think it is not clear enough and the doc is on the perspective
> of echarts user but not echarts contributor.
> 
> I will add instruction of "how to build from the source code" to
> `README.md` directly,
> and add the entry of `npm run build` and `npm run build:watch` to
> `package.json`.
> Hope that makes it better.
> 
> Because it is an enhancement, could we include this modification of
> `README.md`
> in the future release, but not in this release?

Yes. Please make the change for the future while we continue this VOTE thread!

Regards,
Dave
> 
> 
> Thanks,
> ------------------------------
> Su Shuang (100pah)
> ------------------------------
> 
> 
> 
>> On Thu, 12 Sep 2019 at 17:25, Furkan KAMACI <furkankamaci@gmail.com> wrote:
>> 
>> Hi,
>> 
>> +1 from me.
>> 
>> I checked:
>> - Incubating in name
>> - DISCLAIMER exists
>> - LICENSE and NOTICE are fine
>> - No unexpected binary files
>> - Checked PGP signatures
>> - Code compiles and tests successfully run
>> 
>> I agree with Justin, build instructions should be more clear. On the other
>> hand, I'm not sure about the sha512 checksum file format.
>> 
>> Kind Regards,
>> Furkan KAMACI
>> 
>> On Thu, Sep 12, 2019 at 6:01 AM Justin Mclean <justin@classsoftware.com>
>> wrote:
>> 
>>> Hi,
>>> 
>>> +1 binding
>>> 
>>> I checked:
>>> - incubating in a name
>>> - signature sand hashes correct
>>> - DISCLAIMER exists
>>> - LICENS and NOTICE file
>>> - Now unexpected binary files in the release
>>> - All source files have ASF headers
>>> - Compiled from source release
>>> 
>>> It would be good to see some build instruction in the source release.
>>> There’s a build directory but it unclear what need to be done to build
>> it.
>>> I figured it out but it's not exactly obvious what is needed to be done.
>>> 
>>> Thanks,
>>> Justin
>>> 
>>> 
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: general-help@incubator.apache.org
>> 


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message