incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Date Sat, 14 Sep 2019 19:09:12 GMT
Hi,

+1 (binding)

I checked:
- incubating in name
- signatures and hashes file
- DISCLAIMER exists (work in progress version)
- LICENSE is missing information c
- NOTICE include license information which should be in LICENSE (see below)
- no unexpected binaries
- All source files have ASF headers
- Can compile on OSX (Mojave) and all tests pass

If some code license is unknown it's best to ask the author what is it, or better still ask
them to license it under a permissive license that’s compatible with the Apache license.
As well as the two items mentioned in NOTICE you may also need to check the licenses of code
in these files [1][2]

Thanks,
Justin

1. ./fi/include/reverse_purge_hash_map.hpp
2. ./fi/include/frequent_items_sketch.hpp
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message