incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Furkan KAMACI <furkankam...@gmail.com>
Subject Re: [VOTE] Release Apache ECharts (incubating) 4.3.0 (release candidate 2)
Date Thu, 12 Sep 2019 09:25:09 GMT
Hi,

+1 from me.

I checked:
- Incubating in name
- DISCLAIMER exists
- LICENSE and NOTICE are fine
- No unexpected binary files
- Checked PGP signatures
- Code compiles and tests successfully run

I agree with Justin, build instructions should be more clear. On the other
hand, I'm not sure about the sha512 checksum file format.

Kind Regards,
Furkan KAMACI

On Thu, Sep 12, 2019 at 6:01 AM Justin Mclean <justin@classsoftware.com>
wrote:

> Hi,
>
> +1 binding
>
> I checked:
> - incubating in a name
> - signature sand hashes correct
> - DISCLAIMER exists
> - LICENS and NOTICE file
> - Now unexpected binary files in the release
> - All source files have ASF headers
> - Compiled from source release
>
> It would be good to see some build instruction in the source release.
> There’s a build directory but it unclear what need to be done to build it.
> I figured it out but it's not exactly obvious what is needed to be done.
>
> Thanks,
> Justin
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message