incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jaroslav Tulach <>
Subject Re: [VOTE] Release 1.6 of NetBeans HTML/Java API
Date Tue, 27 Nov 2018 05:05:19 GMT
Thanks Bertrand for your reply. I've just found it via the web interface:

Comments below...

On 2018/11/26 10:34:34, Bertrand Delacretaz <> wrote: 
> On Sun, Nov 18, 2018 at 5:48 AM Jaroslav Tulach> 
> <> wrote:> 
> > ...As a result of such unison approval, I'd like to ask you to hold the> 
> > Incubator PMC vote to release:> 
> >
> +1 for the release of> 

thanks for your +1 vote!

> with 
> I haven't checked binaries or Maven artifacts.> 
> SHA256 digest matches (I think the other ones should be removed),> 
> The build with "mvn clean install" didn't work, I got> 
> > Running TestSuite> 
> > Configuring TestNG with: TestNG652Configurator> 
> > java.lang.Exception: Error> 
> >    at 
> Not necessarily a blocker for the release from my point of view.> 
> Tested with java version "1.8.0_171 and Apache Maven 3.6.0.> 

This is the same behavior as reported by others and now tracked as
It is harmless.

> One thing that I noticed but do not consider a blocker, the file> 
> ./ko4j/src/main/resources/org/netbeans/html/ko4j/knockout-3.4.0.js> 
> is distributed minified which IMO doesn't match the spirit of> 
> releasing source code - reviewing that code is next to impossible, I'd> 
> prefer the actual source code to be distributed and minified during> 
> the build if needed.> 

This has also been observed by Justin and I reported:
The file matches the official download from website
and I thought it is better to have an exact copy rather than create own 
minified version. I could download it during build however.

Thanks for your review.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message