incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John D. Ament" <johndam...@apache.org>
Subject Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC4
Date Thu, 18 May 2017 03:03:06 GMT
On Wed, May 17, 2017 at 7:57 PM sospartan <sospartan@gmail.com> wrote:

> John,
> Thanks for the review.
> I don't understand the issue with "sub-directory". Is there any standard
> directory structure for source release?
>


Typically the release contents are simply in the root directory.  There
should not be a subdirectory where all the contents exist.


>
> John D. Ament <johndament@apache.org>于2017年5月17日 周三下午11:41写道:
>
> > sospartan,
> >
> > Couple of things noticed:
> >
> > - Your email still points to your non-ASF hosted website.  Don't forget
> to
> > point to your ASF website.
> > - The source release still contains a sub-directory.
> > - Its still not clear to me how to create the binary.
> > - Your package.json points still to old alibaba repos and not ASF repos
> >
> > I would like to see these 4 issues fixed for next release.
> >
> > LICENSE file looks good, minor typos (still need to fix the extra
> comments)
> > NOTICE file looks fine
> > DISCLAIMER is present.
> > No binaries that I can find.
> >
> > +1
> >
> > John
> >
> > On Mon, May 15, 2017 at 5:24 AM sospartan <sospartan@apache.org> wrote:
> >
> > > Hi IPMC,
> > >
> > > I'm calling a vote for Weex-incubating 0.12.0-RC4 release.
> > > In this release, source tarball only include files necessary to build
> > Weex
> > > SDK.
> > > All binaries were excluded.
> > > A build README(README_RELEASE.md)  is in the tarball now.
> > >
> > > Thanks for peoples who were taking time to review our last RC (RC3).
> I'm
> > > Hoping
> > > this RC is doing better.
> > >
> > > The PPMC vote for this release has passed:
> > > https://lists.apache.org/thread.html/0e05de680b315e453fe8643ff297d5
> > > ebfb9cdd30ea2c982e33854ff5@%3Cdev.weex.apache.org%3E
> > >
> > > The tag to be voted upon:
> > > https://git-wip-us.apache.org/repos/asf?p=incubator-weex.git
> > > ;a=shortlog;h=refs/tags/0.12.0-rc4
> > >
> > > The commit hash:
> > >
> https://git-wip-us.apache.org/repos/asf?p=incubator-weex.git;a=commit;h=
> > > e19ef8a4acc39cd8db2cf3be4f8369f6d7a0bb43
> > > <
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-weex.git;a=commit;h=e19ef8a4acc39cd8db2cf3be4f8369f6d7a0bb43
> > >
> > >
> > > The source tarball can be found at:
> > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/weex/0.12.0-incubating/RC4/
> > >
> > > The fingerprint of key to sign release artifacts:
> > > 97B9 6598 A6A3 B63C 53BD  77E9 44C5 2286 22B9 7784
> > >
> > > Release artifacts are signed with the following key:
> > > https://dist.apache.org/repos/dist/dev/incubator/weex/KEYS
> > >
> > > Release note about this version:
> > > https://issues.apache.org/jira/browse/WEEX-26
> > >
> > > This vote will remain open for at least 72 hours.
> > > Please vote on releasing this RC.
> > >
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove (and reason why)
> > >
> > > --
> > > Best Regards!
> > > ------------------------------
> > >
> > > sospartan
> > > https://weex-project.io
> > >
> >
> --
> sospartan
> Phone:13588488290
> HangZhou
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message