incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John D. Ament" <johndam...@apache.org>
Subject Re: Airflow voting on release artifacts
Date Tue, 25 Apr 2017 10:51:44 GMT
I'll point out that this is a great conversation and set of questions to
have with your mentors first, the IPMC later if they didn't respond/give
you a clear path forward.  Did you engage with them?

I personally hate seeing rc's being put forward to the incubator.  Most of
us use git these days, branches are cheap.  Even in my $dayjob when rolling
a release we always create a release branch, cut the release from there.
If something broke delete it from our internal artifact repository and drop
the branch - effectively starting over.

Would following an approach like that work for you?

John

On Tue, Apr 25, 2017 at 5:18 AM Bolke de Bruin <bdbruin@gmail.com> wrote:

> Hi Niclas,
>
> Is this Java or Python? I can only find Java for Polygene.
>
> Furthermore, how do you manage this you repository? Do you have the
> release already set in one of your files, e.g. something like this:
>
> https://github.com/apache/incubator-airflow/blob/v1-8-test/airflow/version.py
> <
> https://github.com/apache/incubator-airflow/blob/v1-8-test/airflow/version.py
> >
>
> The build system generates the metadata from there, which is used by the
> package installers (e.g. pip).
>
> Cheers
> Bolke
>
>
> > On 25 Apr 2017, at 10:47, Niclas Hedhman <niclas@hedhman.org> wrote:
> >
> > We have a similar issue in Polygene, but the internal version is simply
> the
> > expected version, say 1.2.3 and the RC has the different file name. No
> > packagers will ever get the -RC named artifact and no confusion is among
> > community members as they are aware of this. IF the RC passes, then the
> > rename can happen. IF the RC doesn't happen, you can rebuild with new
> > content and same internal version.
> >
> > Cheers
> > Niclas
> >
> > On Tue, Apr 25, 2017 at 4:43 PM, Bolke de Bruin <bdbruin@gmail.com>
> wrote:
> >
> >> Hi Bertrand,
> >>
> >>> On 25 Apr 2017, at 09:04, Bertrand Delacretaz <
> >> bdelacretaz@codeconsult.ch> wrote:
> >>>
> >>> Hi,
> >>>
> >>> On Mon, Apr 24, 2017 at 10:18 PM, Chris Riccomini <
> criccomini@apache.org>
> >> wrote:
> >>>> ...Hitesh recently raised the issue that the artifact that passes the
> >> vote
> >>>> MUST be the one that we actually release...
> >>>
> >>> Yes in terms of having the same binary digests and signatures, but
> >>> renaming the files is fine IMO, especially for removing an -rc suffix
> >>> which makes total sense. I would just add that step to your release
> >>> process documentation to make it clear.
> >>>
> >>>> ...Rename/rebuild after final vote (This is what Airflow is doing, and
> >> Beam
> >>>> does this, I believe)...
> >>>
> >>> I'd say rename yes but rebuild no, in order to keep the same digests
> >>> and signatures.
> >>>
> >>
> >> As mentioned earlier, that seems not to be possible. The metadata
> >> (filename) and version information inside the package need to be in
> sync.
> >> This how the python build tools and python ecosystem works.
> >>
> >> - Bolke.
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail: general-help@incubator.apache.org
> >>
> >>
> >
> >
> > --
> > Niclas Hedhman, Software Developer
> > http://polygene.apache.org - New Energy for Java
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message