incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <>
Subject Re: [VOTE] TinkerPop 3.1.1-incubating Release
Date Thu, 11 Feb 2016 23:45:39 GMT

+1 binding

For the source release I checked:
- release name contains incubating
- signatures and hashed good
- disclaimer exists
- LICENSE and NOTICE have some minor issues (see below)
- all source files have apache headers
- no unexpected binary files
- can compile from source

License and notice issues:
- short form of licenses is prefered
- NOTICE contains a little too much text, no need for "Apache TinkerPop contains subcomponents..”
or the " section 4(d)” bit
- Not complying with the terms of the MIT license i.e. "The above copyright notice and this
permission notice shall be included in all copies or substantial portions of the Software.”
 The copyright notices are missing. This is why short form in LICENSE is preferred [1] with
a pointer to the actual text of the license. That way you have an exact copy of each license
which would include the copyright notice.

For console release as above and:
- LICENSE is missing MIT licensed  foundation stylesheet for CodeRay (in ./docs/reference/index.html)
- jbcrypt is listed as BSD but it’s actually a BSD/MIT style ISC license (and the way it’s
included means the license text is wrong)
- Not complying with BSD license terms i.e. "Redistributions in binary form must reproduce
the above copyright notice” and copyright notices are missing.

For the sever release same as both sections above.

The LICENSE and NOTICE are a huge improvement over last release and for a project that bindles
a lot of things they are in much better shape than a majority of other incubating projects.
Great work!


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message