incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matthieu Riou <>
Subject Re: Review-Then-Commit
Date Wed, 11 Nov 2009 17:20:27 GMT
On Wed, Nov 11, 2009 at 8:31 AM, Daniel Kulp <> wrote:

> As Martijn alluded to, I think we'd need some more context as to why and
> how
> they use RTC.
Yes, sorry for the lack of details. The context is Cassandra and they're
doing RTC by community choice. They all seem to agree that RTC is the best
for their own codebase given that some parts of it can be pretty tricky. And
even committers who aren't too big on RTC generally speaking seem to agree
that it's working well for them (see [1] for the whole thread, including
Paul's objection). So it really seems to be community driven.

Thank for the inputs.



If all the reviews are done by a single person because that is what they
> want,
> THAT would be a problem.   If the reviews are a community driven thing and
> the
> community thinks that's the best way for the project, that's perfectly
> fine.
> The main thing is if the community allows the committers (and ALL the
> committers) to participate in all aspects of the development, including the
> reviews.   My main issue with RTC is that it often degrades into a single
> BD
> doing the reviews and pretty much dictating the direction of code.
> Everyone
> else ends up in a "make him happy" mode.  That would definitely be a bad
> situation.
> Again, if the community is OK with it and it looks like the process is
> working
> and everyone is involved or has the chance to be involved, it's not a
> problem.
> Dan
> On Wed November 11 2009 11:09:39 am Matthieu Riou wrote:
> > Hi guys,
> >
> > What's the take of other mentors and the IPMC on podlings practicing RTC?
> > I'm asking because some seem to see it as a blocker for graduation
> whereas
> >  I see it much more as a development methodology with little community
> >  impact and therefore no real influence on graduation. Strong opinions
> >  here?
> >
> > Thanks,
> > Matthieu
> >
> --
> Daniel Kulp

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message