incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Döbele <>
Subject Re: [VOTE] apache-empire-db-2.0.3-incubating and apache-empire-struts2-ext-1.0.3-incubating release
Date Mon, 08 Sep 2008 14:26:32 GMT
Hi Thomas,

thanks very much for your detailed analysis.
It's a shame we missed that on our empire-db-dev vote.

Jörg has already commented about the md5 and sha file format.

As far as I understand it, there are two major problems with the empire-struts2-ext-1.0.3

1. the missing freemarker info in the NOTICE file (we'll add HSQLDB as well)

2. the inclusion of servlet-api.jar and jsp-api.jar. 

We can leave the servlet-api.jar and jsp-api.jar out of the distribution but only for the
price that it won't compile off the shelf, and this will make it more difficult for beginners
to run the sample. Does anyone have a suggestion how to deal with that (given that we use
maven only for a forthcoming release)?

Since all issues concern the empire-struts2-ext-1.0.3 distribution, does this mean that the
-1 is for this part only? And would you give a +1 for the empire-db-2.0.3 release?
(Just want to make sure, we're on the right track).

Since we built the 2.0.3 / 1.0.3 release we have made some improvemets and bugfixes. I suggest
skipping these releases and continuing with the 2.0.4 and 1.0.4 release.


Thomas Fischer wrote:
> I checked the Release candidate against the incubator release check list 
> [1] and found the following:
> - All Files unpack correctly.
> - The code builds from source.
> - the status page is not up to date.
> - All files have a valid md5 sum, sha hash and are signed properly. 
> However, the format of the md5 and sha sum files is not linux standard, 
> making automatic checks more difficult. I am not sure whether that causes 
> mirroring problems.
> - There is not yet a KEYS file.
> - The NOTICE and various LICENSE files are ok, except the following:
> -- The asf part is not the first part of the /NOTICE file in the db and 
> the struts2 extension. See [2]
> -- freemarker is not in the /NOTICE file of the struts2 extension. 
> However, the freemarker License requires it. The appropriate passage from 
> the Freemarker license needs to be copied into the NOTICE file.
> -- The HSQLDB library is not mentioned in the /NOTICE file of the db part. 
> Ihe HSQL License does not require it, but I'd add it anyway.
> - The Servlet API and JSP API are contained in the struts 2 extension 
> distribution. The Source code is not included; neither there is a 
> prominent notice to where it can be obtained. This is against the CDDL 
> License [3] and apache licensing policy [4].
> - The README Files are ok except the following:
> -- The README File of the struts2 extension is misleading. It is said 
> there that "This Extension works with the Sysdeo-DevLoader". I'd hope it 
> works in a standalone servlet container as well ?
> -- The README should contain information how the code can be built from 
> source. In the db part it should say where the build.xml is located; in 
> the struts2 extension this part misses.
> - The documentation of the struts2 extension is a bit sparse. It contains 
> javadocs and a small Readme. Perhaps the documentation from the web site 
> can be included ?
> - There is a file apache-empire-struts2-ext-1.0.3-incubating.tar.gzmd5, 
> which content does not fit its name. Probably it is there by error.
> - The example applications contain all the libraries in the /lib directory 
> again. For bandwith reasons, it would be better to supply an ant script 
> which compiles and packages the examples by using the /lib files.
> - The RAT reports look good.
> [1]
> [2]
> [3]
> [4]
> Regarding the license issues, I regret that I am forced to vote -1 on this 
> Release Candidate. I am sorry that I could not check the RC while the 
> vote was on the dev list, but I had a lot of work to do this week.
>      Regards,
>        Thomas
> P.S. Who is responsible for updating the status page ? Should that be 
> done by the mentor, or can I as IPMC member also do that ?

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message