celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] Oipo commented on a change in pull request #317: prevents unneeded suspend triggers in the dm component
Date Mon, 15 Feb 2021 08:16:42 GMT

Oipo commented on a change in pull request #317:
URL: https://github.com/apache/celix/pull/317#discussion_r576006896



##########
File path: libs/framework/src/dm_service_dependency.c
##########
@@ -342,6 +342,22 @@ bool celix_dmServiceDependency_isTrackerOpen(celix_dm_service_dependency_t*
depe
     return isOpen;
 }
 
+bool celix_dmServiceDependency_isSetCallbackConfigured(celix_dm_service_dependency_t* dependency)
{
+    bool isUsed;

Review comment:
       This is old-style C convention. Is that still something Celix goes for? (no judgement
meant here)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message