celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] pnoltes commented on pull request #279: Feature/tcp admin msg segmentation
Date Thu, 17 Dec 2020 14:42:21 GMT

pnoltes commented on pull request #279:
URL: https://github.com/apache/celix/pull/279#issuecomment-747479169


   Our IVV test where failing for the updated PubSub TCP Admin,  apparently this update does
not work with wire protocol v1. 
   
   @rbulter Is it correct that the updated PubSub TCP Admin does not work with wire protocol
v1?
   If not, please add a pubsub tcp admin test with wire protocol v1. 
   If correct, please update the tcp admin match , so that only wire protocol v2 is searched
and supported. 
   
   Maybe add an pubsubEndpoint_matchPublisherWithRequestedProtocolAndSerializer function which
is used by the 'normal' pubsubEndpoint_matchPublisher and can be called directly by the tcp
admin match with a filled in requestedProtcol="envelope-v2" argument. And the same for pubsubEnd_matchSubscriber.
   This should enforce the tcp admin to use the correct wire protocol or fail in the match.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message