celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] Oipo commented on a change in pull request #279: Feature/tcp admin msg segmentation
Date Wed, 16 Dec 2020 12:14:54 GMT

Oipo commented on a change in pull request #279:
URL: https://github.com/apache/celix/pull/279#discussion_r544250591



##########
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_handler.c
##########
@@ -1187,6 +1245,32 @@ char *pubsub_tcpHandler_get_interface_url(pubsub_tcpHandler_t *handle)
{
     }
     return url;
 }
+//
+// get interface URL
+//
+char *pubsub_tcpHandler_get_connection_url(pubsub_tcpHandler_t *handle) {
+    hash_map_iterator_t iter =

Review comment:
       Missing `celixThreadRwlock_writeLock(&handle->dbLock);` in this function or
in the caller function `pubsub_tcpTopicSender_url`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message