celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] Oipo commented on a change in pull request #293: Feature/add build to svc dep creation
Date Wed, 11 Nov 2020 21:34:32 GMT

Oipo commented on a change in pull request #293:
URL: https://github.com/apache/celix/pull/293#discussion_r521651647



##########
File path: libs/framework/include/celix/dm/Component.h
##########
@@ -17,24 +17,21 @@
  * under the License.
  */
 
-#ifndef CELIX_DM_COMPONENT_H
-#define CELIX_DM_COMPONENT_H
+#pragma once
 
 #include "celix/dm/types.h"
 #include "dm_component.h"
 
 #include <map>
 #include <string>
 #include <vector>
+#include <atomic>

Review comment:
       I don't see this header being used anywhere, can this be removed or am I missing something?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message