celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] Oipo commented on a change in pull request #292: zmq admin serializer change
Date Wed, 11 Nov 2020 12:42:41 GMT

Oipo commented on a change in pull request #292:
URL: https://github.com/apache/celix/pull/292#discussion_r521331375

File path: bundles/pubsub/test/test/serializer_activator.cc
@@ -0,0 +1,87 @@
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ *  KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+#include "celix_constants.h"
+#include <unistd.h>
+#include "celix_api.h"
+#include "../../pubsub_spi/include/pubsub_message_serialization_service.h"
+#include "../../pubsub_spi/include/pubsub_constants.h"
+#include "msg.h"
+struct activator {
+    long serId;
+    pubsub_message_serialization_service_t svc;
+celix_status_t bnd_start(struct activator *act, celix_bundle_context_t *ctx) {
+#pragma GCC diagnostic ignored "-Wunused-parameter"

Review comment:
       This is needed because the lambdas ignore parameters. Even when simply removing the
names, I kept getting errors. Since this is just a test file, I opted for ignoring the warnings
(which get turned into errors due to `-Werrors`).

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

View raw message