celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] Oipo commented on a change in pull request #282: Hotfix/rsa deadlock
Date Thu, 10 Sep 2020 08:13:22 GMT

Oipo commented on a change in pull request #282:
URL: https://github.com/apache/celix/pull/282#discussion_r486149995



##########
File path: bundles/remote_services/remote_service_admin_dfi/src/remote_service_admin_dfi.c
##########
@@ -555,8 +633,16 @@ celix_status_t remoteServiceAdmin_removeExportedService(remote_service_admin_t
*
             arrayList_destroy(exports);
         }
 
-        exportRegistration_close(registration);
-        exportRegistration_destroy(registration);
+        if (CELIX_RSA_USE_STOP_EXPORT_THREAD) {

Review comment:
       This is a code clone from above. Perhaps refactor into a macro or a function?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message