celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] glimmerveen commented on a change in pull request #203: Feature/osgi promise
Date Tue, 21 Apr 2020 06:15:50 GMT

glimmerveen commented on a change in pull request #203:
URL: https://github.com/apache/celix/pull/203#discussion_r411899002

File path: misc/experimental/promise/api/celix/PromiseFactory.h
@@ -0,0 +1,50 @@
+ *Licensed to the Apache Software Foundation (ASF) under one
+ *or more contributor license agreements.  See the NOTICE file
+ *distributed with this work for additional information
+ *regarding copyright ownership.  The ASF licenses this file
+ *to you under the Apache License, Version 2.0 (the
+ *"License"); you may not use this file except in compliance
+ *with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *Unless required by applicable law or agreed to in writing,
+ *software distributed under the License is distributed on an
+ * KIND, either express or implied.  See the License for the
+ *specific language governing permissions and limitations
+ *under the License.
+ */
+#pragma once
+#include "celix/Deferred.h"
+namespace celix {
+    class PromiseFactory {

Review comment:
       Adding a `resolved` and `failed` factory methods should be relatively easy, and increases
usability in areas where the result is not calculated asynchronously.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

View raw message