celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] pnoltes commented on a change in pull request #199: Bugfix/zmq fixes
Date Thu, 16 Apr 2020 12:09:28 GMT
pnoltes commented on a change in pull request #199: Bugfix/zmq fixes
URL: https://github.com/apache/celix/pull/199#discussion_r409504751
 
 

 ##########
 File path: bundles/pubsub/examples/pubsub/interceptors/src/ps_interceptor_activator.c
 ##########
 @@ -26,52 +26,54 @@
 struct interceptorActivator {
     first_interceptor_t *interceptor;
     uint64_t interceptorSvcId;
+    pubsub_interceptor_t *interceptorSvc;
 
     second_interceptor_t *secondInterceptor;
     uint64_t secondInterceptorSvcId;
+    pubsub_interceptor_t *secondInterceptorSvc;
 
 Review comment:
   I know this is just a name change, but this does not need to be a pointer.
   so:
   ```C
   struct interceptorActivator {
        uint64_t interceptorSvcId;
        pubsub_interceptor_t interceptorSvc;
        uint64_t secondInterceptorSvcId;
        pubsub_interceptor_t secondInterceptorSvc;
   };
   ```
   
   should also works and save two malloc/callocs 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message