celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] pnoltes commented on a change in pull request #187: Added interceptors to RSA, currently only DFI is updated.
Date Tue, 07 Apr 2020 15:16:47 GMT
pnoltes commented on a change in pull request #187: Added interceptors to RSA, currently only
DFI is updated.
URL: https://github.com/apache/celix/pull/187#discussion_r404890347
 
 

 ##########
 File path: bundles/remote_services/remote_service_admin_dfi/src/remote_service_admin_dfi.c
 ##########
 @@ -813,6 +825,22 @@ static celix_status_t remoteServiceAdmin_send(void *handle, endpoint_description
     if(!curl) {
         status = CELIX_ILLEGAL_STATE;
     } else {
+        struct curl_slist *metadataHeader = NULL;
+        if (metadata != NULL && celix_properties_size(metadata) > 0) {
+            const char *key = NULL;
+            CELIX_PROPERTIES_FOR_EACH(metadata, key) {
+                const char *val = celix_properties_get(metadata, key, "");
+                size_t length = strlen(key) + strlen(val) + 18; // "X-RSA-Metadata-key: val\0"
 
 Review comment:
   use celix_utils_strlen (is bounded using a strnlen)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message