celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] pnoltes commented on a change in pull request #185: Add custom serialization service for custom delete functions in RSA
Date Tue, 07 Apr 2020 15:05:08 GMT
pnoltes commented on a change in pull request #185: Add custom serialization service for custom
delete functions in RSA
URL: https://github.com/apache/celix/pull/185#discussion_r404877618
 
 

 ##########
 File path: bundles/remote_services/remote_services_api/include/remote_custom_serialization_service.h
 ##########
 @@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ *  KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#ifndef CELIX_REMOTE_CUSTOM_SERIALIZATION_SERVICE_H
+#define CELIX_REMOTE_CUSTOM_SERIALIZATION_SERVICE_H
+
+#define RSA_CUSTOM_SERIALIZATION_SERVICE_NAME "rsa.custom.serialization"
+#define RSA_SERVICE_TARGETED_ID "targeted.service.id"
 
 Review comment:
   I do not like a target service id. This means that the service needs to be registered before
the custom serialisation service and I would prefer it the other way around. 
   
   Or we should make the custom serialization service mandatory. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message