celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] abroekhuis commented on a change in pull request #186: Cleanup dm interface
Date Mon, 06 Apr 2020 09:12:10 GMT
abroekhuis commented on a change in pull request #186: Cleanup dm interface
URL: https://github.com/apache/celix/pull/186#discussion_r403940185
 
 

 ##########
 File path: libs/framework/include/celix/dm/Component.h
 ##########
 @@ -232,17 +232,29 @@ namespace celix { namespace dm {
          * @return the DM Component reference for chaining (fluent API)
          */
         Component<T>& setCallbacks(
-            int (T::*init)(),
-            int (T::*start)(),
-            int (T::*stop)(),
-            int (T::*deinit)()
+                int (T::*init)(),
+                int (T::*start)(),
+                int (T::*stop)(),
+                int (T::*deinit)()
         );
         /**
          * Remove the previously registered callbacks for the component life cycle control
          *
          * @return the DM Component reference for chaining (fluent API)
          */
         Component<T>& removeCallbacks();
+
+        /**
+         * Safely copies a std::string into a char* buffer
+         * @param input string to copy
+         * @param dst buffer to allocate into, owner is responsible for freeing memory
+         */
+        void copyString(const std::string& input, char **dst)
 
 Review comment:
   Should this be used for all c_str calls?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message