celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] abroekhuis commented on issue #185: Add custom serialization service for custom delete functions in RSA
Date Mon, 06 Apr 2020 07:48:48 GMT
abroekhuis commented on issue #185: Add custom serialization service for custom delete functions
in RSA
URL: https://github.com/apache/celix/pull/185#issuecomment-609632407
 
 
   > > > Clang on macOS fails because of a bug in clang: https://bugs.llvm.org/show_bug.cgi?id=21629
   > > > Suggest adding -Wno-missing-braces.
   > > 
   > > 
   > > Why is it an issue suddenly? What line of code triggers it?
   > > From the logs:
   > 
   > ```
   > 2020-04-06T07:35:34.3719830Z /Users/runner/runners/2.168.0/work/celix/celix/bundles/remote_services/remote_service_admin_dfi/src/remote_service_admin_dfi.c:275:46:
error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
   > 2020-04-06T07:35:34.3820920Z     celix_service_tracking_options_t opts = {0};
   > ```
   > 
   > Using {0} is a standard compliant way to initialize all members of a struct to 0.
   
   OK, I see, instead of {0}, can you use CELIX_EMPTY_SERVICE_TRACKING_OPTIONS, as is done
in other places. That way we can leave the build options the same.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message