celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] abroekhuis commented on a change in pull request #185: Add custom serialization service for custom delete functions in RSA
Date Mon, 06 Apr 2020 07:09:13 GMT
abroekhuis commented on a change in pull request #185: Add custom serialization service for
custom delete functions in RSA
URL: https://github.com/apache/celix/pull/185#discussion_r403870080
 
 

 ##########
 File path: bundles/remote_services/remote_services_api/include/remote_custom_serialization_service.h
 ##########
 @@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ *  KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#ifndef CELIX_REMOTE_CUSTOM_SERIALIZATION_SERVICE_H
 
 Review comment:
   This header has a TODO to add serialize/deserialize to it as well, does that make sense?
   @pnoltes I think it does, just want to make sure we don't overlook something. Is it, for
example, possible to not use a serialization solution/service?
   Also, currently serialization is not in a service at all, if we do this, I think it makes
sense to move it asap as well. Current situation could just be a wrapper for the used json_rpc
I think.
   Also, if we do it like this for the RSA, I think a similar solution is needed for the PSA,
wdyt?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message