celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] abroekhuis commented on a change in pull request #172: Refactor TcpAdmin and add interfacing for VectorIoSerialisation
Date Thu, 02 Apr 2020 18:23:29 GMT
abroekhuis commented on a change in pull request #172: Refactor TcpAdmin and add interfacing
for VectorIoSerialisation
URL: https://github.com/apache/celix/pull/172#discussion_r402521453
 
 

 ##########
 File path: bundles/pubsub/pubsub_spi/include/pubsub_utils_url.h
 ##########
 @@ -0,0 +1,55 @@
+/*
 
 Review comment:
   @pnoltes @rbulter what do you guys think? Does it make sense to move this shared code to
something like pubsub_shared? I agree it is generic enough to have in here, but I don't thinks
it should be part of spi.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message