celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] rbulter commented on a change in pull request #172: Refactor TcpAdmin and add interfacing for VectorIoSerialisation
Date Wed, 01 Apr 2020 19:20:45 GMT
rbulter commented on a change in pull request #172: Refactor TcpAdmin and add interfacing for
VectorIoSerialisation
URL: https://github.com/apache/celix/pull/172#discussion_r401852475
 
 

 ##########
 File path: bundles/pubsub/pubsub_spi/src/pubsub_utils_match.c
 ##########
 @@ -227,6 +228,7 @@ double pubsub_utils_matchSubscriber(
     pubsub_get_topic_properties_data_t data;
     data.isPublisher = false;
     data.topic = celix_properties_get(svcProperties, PUBSUB_SUBSCRIBER_TOPIC, NULL);
+    data.scope = celix_properties_get(svcProperties, PUBSUB_SUBSCRIBER_SCOPE, PUBSUB_SUBSCRIBER_SCOPE_DEFAULT);
 
 Review comment:
   I have prepare the code for scope = NULL, but I don't need the complete PR for testing
this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message