celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] rbulter commented on a change in pull request #172: Refactor TcpAdmin and add interfacing for VectorIoSerialisation
Date Wed, 01 Apr 2020 17:54:46 GMT
rbulter commented on a change in pull request #172: Refactor TcpAdmin and add interfacing for
VectorIoSerialisation
URL: https://github.com/apache/celix/pull/172#discussion_r401802503
 
 

 ##########
 File path: bundles/pubsub/test/test/test_endpoint_runner.cc
 ##########
 @@ -18,22 +18,54 @@
  */
 
 #include "celix_api.h"
 
 Review comment:
   The TcpAdmin tests already exists for more then 6 months. When the pubsub tests are converted
to gtest. These can be converted to gtest. This test tests the tcp static endpoint functionality
and is variant of the pubsub unit tests. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message