celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] rbulter commented on a change in pull request #172: Refactor TcpAdmin and add interfacing for VectorIoSerialisation
Date Wed, 01 Apr 2020 17:38:29 GMT
rbulter commented on a change in pull request #172: Refactor TcpAdmin and add interfacing for
VectorIoSerialisation
URL: https://github.com/apache/celix/pull/172#discussion_r401792685
 
 

 ##########
 File path: bundles/pubsub/pubsub_admin_zmq/src/pubsub_zmq_topic_sender.c
 ##########
 @@ -529,12 +526,17 @@ static int psa_zmq_topicPublicationSend(void* handle, unsigned int
msgTypeId, co
 
         if (status == CELIX_SUCCESS /*ser ok*/) {
             pubsub_protocol_message_t message;
-            message.payload.payload = serializedOutput;
-            message.payload.length = serializedOutputLen;
+            message.payload.payload = NULL;
+            message.payload.length = 0;
+            message.metadata.metadata = NULL;
 
             void *payloadData = NULL;
             size_t payloadLength = 0;
-            entry->protSer->encodePayload(entry->protSer->handle, &message,
&payloadData, &payloadLength);
+            if (serializedOutput) {
+              message.payload.payload = serializedOutput->iov_base;
 
 Review comment:
   I have fixed this

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message