celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] abroekhuis commented on a change in pull request #172: Refactor TcpAdmin and add interfacing for VectorIoSerialisation
Date Wed, 01 Apr 2020 11:42:41 GMT
abroekhuis commented on a change in pull request #172: Refactor TcpAdmin and add interfacing
for VectorIoSerialisation
URL: https://github.com/apache/celix/pull/172#discussion_r401545652
 
 

 ##########
 File path: bundles/pubsub/pubsub_spi/include/pubsub_protocol.h
 ##########
 @@ -28,39 +28,78 @@
 
 typedef struct pubsub_protocol_header pubsub_protocol_header_t;
 
+/**
+ * The protocol header structure, contains the information about the message payload and
metadata
+ */
 struct pubsub_protocol_header {
-    unsigned int msgId;
-    unsigned short msgMajorVersion;
-    unsigned short msgMinorVersion;
-
-    unsigned int payloadSize;
-    unsigned int metadataSize;
+  /** message payload identification attributes */
+    unsigned int msgId; /*!< Message id of the payload */
 
 Review comment:
   Curious about this notation: !< ... does it have some meaning? If not, does it make
sense to clean this up? msgId with a comment "message id" etc doesn't add much imo.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message