celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] abroekhuis commented on a change in pull request #172: Refactor TcpAdmin and add interfacing for VectorIoSerialisation
Date Wed, 01 Apr 2020 11:42:40 GMT
abroekhuis commented on a change in pull request #172: Refactor TcpAdmin and add interfacing
for VectorIoSerialisation
URL: https://github.com/apache/celix/pull/172#discussion_r401550373
 
 

 ##########
 File path: bundles/pubsub/pubsub_spi/src/pubsub_utils.c
 ##########
 @@ -143,12 +143,17 @@ celix_properties_t *pubsub_utils_getTopicProperties(const celix_bundle_t
*bundle
         bundle_getEntry((celix_bundle_t *)bundle, ".", &bundleRoot);
 
         if (bundleRoot != NULL) {
-            asprintf(&topicPropertiesPath, "%s/META-INF/topics/%s/%s.properties", bundleRoot,
isPublisher? "pub":"sub", topic);
+            asprintf(&topicPropertiesPath, "%s/META-INF/topics/%s/%s.%s,properties",
bundleRoot, isPublisher? "pub":"sub", topic, scope);
 
 Review comment:
   Same here, I would expect the scope to be before the topic, as it also is in the discovery
entry.
   
   Also, typo in the name, "...%s.%s,properties", that comma should be a point.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message