celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] abroekhuis commented on a change in pull request #172: Refactor TcpAdmin and add interfacing for VectorIoSerialisation
Date Wed, 01 Apr 2020 11:42:40 GMT
abroekhuis commented on a change in pull request #172: Refactor TcpAdmin and add interfacing
for VectorIoSerialisation
URL: https://github.com/apache/celix/pull/172#discussion_r401550690
 
 

 ##########
 File path: bundles/pubsub/pubsub_spi/src/pubsub_utils.c
 ##########
 @@ -143,12 +143,17 @@ celix_properties_t *pubsub_utils_getTopicProperties(const celix_bundle_t
*bundle
         bundle_getEntry((celix_bundle_t *)bundle, ".", &bundleRoot);
 
         if (bundleRoot != NULL) {
-            asprintf(&topicPropertiesPath, "%s/META-INF/topics/%s/%s.properties", bundleRoot,
isPublisher? "pub":"sub", topic);
+            asprintf(&topicPropertiesPath, "%s/META-INF/topics/%s/%s.%s,properties",
bundleRoot, isPublisher? "pub":"sub", topic, scope);
             topic_props = celix_properties_load(topicPropertiesPath);
+
             if (topic_props == NULL) {
-                printf("PubSub: Could not load properties for %s on topic %s. Searched location
%s, bundleId=%ld\n", isPublisher? "publication":"subscription", topic, topicPropertiesPath,
bundleId);
+              free(topicPropertiesPath);
+              asprintf(&topicPropertiesPath, "%s/META-INF/topics/%s/%s.properties", bundleRoot,
isPublisher ? "pub" : "sub", topic);
+              topic_props = celix_properties_load(topicPropertiesPath);
+              if (topic_props == NULL) {
+                printf("PubSub: Could not load properties for %s on topic %s. Searched location
%s, bundleId=%ld\n", isPublisher ? "publication" : "subscription", topic, topicPropertiesPath,
bundleId);
 
 Review comment:
   Scope can be added to this message.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message