celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] abroekhuis commented on a change in pull request #172: Refactor TcpAdmin and add interfacing for VectorIoSerialisation
Date Wed, 01 Apr 2020 11:42:40 GMT
abroekhuis commented on a change in pull request #172: Refactor TcpAdmin and add interfacing
for VectorIoSerialisation
URL: https://github.com/apache/celix/pull/172#discussion_r401544042
 
 

 ##########
 File path: bundles/pubsub/pubsub_serializer_avrobin/src/pubsub_avrobin_serializer_impl.c
 ##########
 @@ -49,10 +49,10 @@ struct pubsub_avrobin_serializer {
     log_helper_t *loghelper;
 };
 
-static celix_status_t pubsubMsgAvrobinSerializer_serialize(void *handle, const void *msg,
void **out, size_t *outLen);
-static celix_status_t pubsubMsgAvrobinSerializer_deserialize(void *handle, const void *input,
size_t inputLen, void **out);
-static void pubsubMsgAvrobinSerializer_freeMsg(void *handle, void *msg);
-
+static celix_status_t pubsubMsgAvrobinSerializer_serialize(void *handle, const void *msg,
struct iovec** output, size_t* outputIovLen);
 
 Review comment:
   Shouldn't all those changes be in a different PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message