ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ant] alex-ninja opened a new pull request #147: Make Watchdog for JUnitLauncherTask customizable.
Date Fri, 30 Apr 2021 08:28:24 GMT

alex-ninja opened a new pull request #147:
URL: https://github.com/apache/ant/pull/147


   ### Context
   Currently I'm working on migration of Cassandra to JUnit5 (https://issues.apache.org/jira/browse/CASSANDRA-16630).
There is a nice customization that is used there: before terminating a test by timeout, we
get all stack traces via `jstack` command. It is very useful for troubleshooting purposes.
You can check the reference implementation for JUnit4: https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/JStackJUnitTask.java.
Unfortunately it is impossible to do the same customization for `JUnitLauncherTask` (unlikely
to `JUnitTask`) because everything is hidden (private) now. We want to have a way to easily
extend `Watchdog` created for a task/test monitoring.
   
   ### Summary of the changes
   1. Moved Watchdog creation into a separate method
   2. Made the method protected


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message