ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jaikiran Pai <jaiki...@apache.org>
Subject Re: [ant] branch master updated: add discardOutput and discardError to redirector, apply, exec, java
Date Sun, 21 Mar 2021 04:18:12 GMT

On 20/03/21 11:31 pm, bodewig@apache.org wrote:
> ...
> + */
> +public class NullOutputStream extends OutputStream {
> +
> +    /**
> +     * Shared instance which is safe to use concurrently as the stream
> +     * doesn't hold any state at all.
> +     */
> +    public static NullOutputStream INSTANCE = new NullOutputStream();
> +
> +

Should we consider adding a private constructor to prevent anyone from 
directly instantiating this class? It won't make that major a 
difference, but since we already expose this INSTANCE, it probably is a 
good idea to prevent direct instantiation?


-Jaikiran


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message