ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ant] TheConstructor commented on pull request #140: #64854 Add preserveduplicates option to ResourceList
Date Sun, 06 Dec 2020 21:03:37 GMT

TheConstructor commented on pull request #140:
URL: https://github.com/apache/ant/pull/140#issuecomment-739563468


   I checked that `cachedResources` is only ever accessed through `cache()`, which is `synchronized`.
Is this really a problem? Would declaring `cachedResources` `volatile` and/or assigning the
field just after populating the cache help in your opinion?
   
   To your nits:
   - I am happy to change the name
   - I wasn't quite sure which version could be next, so I thought it would be good to have
something in place, where I can pick up work. -> will insert the version
   - Ok


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message